at_onboarding_cli #134
at_onboarding_cli #134
Conversation
…ibraries into at_onboarding_cli
|
@srieteja I've put instructions for reading from and writing to the SIM card at https://github.com/atsign-company/mwc_demo/tree/trunk/gsm As you won't be using minicom to access it you'll have to use libserialport to connect to /dev/ttyS0 |
There was a problem hiding this comment.
Great work!
I have run through a few test and everything works that I have tried..
The only thing we need to decide is the name of the package..
at_onboarding_cli or just at_onboarding or at_onboarding_dart
My only comment was in the naming of
lib/at_cli_onboarding.dart
the cli before onboarding confused me
@cconstab I have changed the name to at_onboarding_cli for now. We can have further discussion to decide the name if required. |
| @@ -0,0 +1,10 @@ | |||
| import 'dart:core'; | |||
There was a problem hiding this comment.
This import is not necessary. Cause I see String is the only data type that comes from dart sdk. We don't need it. Please LMK if something goes wrong if we remove it.
| } else { | ||
| _atClient ??= await getAtClient(); | ||
| _isPkamAuthenticated = | ||
| (await _atLookup?.authenticate(atOnboardingPreference.privateKey))!; |
There was a problem hiding this comment.
As you strictly wating for true/false value, you can actualy use _atLookup! instead of _atLookup?. Incase if you think _atLookup will be null, then write a if condition for it. The thing what happens is, If _atLookup is null, then _isPkamAuthenticated will be null. The above mentioned is a possible solution or there is an alternative solution, here it is :
_isPkamAuthenticated = await _atLookup?.authenticate(atOnboardingPreference.privateKey) ?? false;
closes atsign-foundation/at_server#474
- What I did
Enabling support to onboard and authenticate atSign's from command-line.
- How I did it
Created a new library that has all the required functionality to onboard and authenticate atSigns.
- How to verify it
This is a work in progress, no unit tests have been written. But temporarily bin/example.dart can verify the functionality.
- Description for the changelog