Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy pubspec.yaml to secondary folder in virtual env #1006

Merged
merged 3 commits into from Oct 27, 2022

Conversation

murali-shris
Copy link
Member

- What I did

  • fixed version issue in virtual env
    - How I did it
  • copied pubspec.yaml to secondary folder in virtual env setup
    - How to verify it
  • TBD

@cpswan
Copy link
Member

cpswan commented Oct 27, 2022

I don't think this will work, as there isn't a pubspec.yaml in the source directory, and we don't want to have one in the ve_base.

I'll take a look at what's needed to copy the pubspec.yaml into place when we build a ve image.

@cpswan
Copy link
Member

cpswan commented Oct 27, 2022

This looks like the culprit:

~/git/github.com/atsign-foundation/at_server/tests/at_functional_test/lib/secondary/base$ ls -la
total 8
drwxr-xr-x 2 chris chris 4096 Oct 27 08:36 .
drwxr-xr-x 3 chris chris 4096 Oct 27 08:36 ..
lrwxrwxrwx 1 chris chris   57 Oct 27 08:36 pubspec.yaml -> ../../../../at_secondary/at_secondary_server/pubspec.yaml

We have a symlink that's been messed up by the recent directory moves.

But that would affect VE in at_functional_tests, not in the atsigncompany/virtualenv:dev_env image.

@cpswan cpswan merged commit fb3bb4a into trunk Oct 27, 2022
@cpswan cpswan deleted the fix_version_bug_virtual_env branch October 27, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants