Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check size of chained exception list in getTraceMessage #235

Merged
merged 2 commits into from
Sep 27, 2022
Merged

fix: check size of chained exception list in getTraceMessage #235

merged 2 commits into from
Sep 27, 2022

Conversation

murali-shris
Copy link
Member

- What I did

  • fixed a bug in at_exception_stack.dart
    - How I did it
  • check the list size is greater than zero before fetching first element
    - How to verify it
  • run the unit test at_exception_stack_test.dart

@murali-shris murali-shris mentioned this pull request Sep 27, 2022
Closed
gkc
gkc approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @murali-shris

@murali-shris murali-shris merged commit 2acf31f into trunk Sep 27, 2022
@murali-shris murali-shris deleted the exception_trace_bug branch September 27, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@VJag VJag VJag approved these changes

@sitaram-kalluri sitaram-kalluri Awaiting requested review from sitaram-kalluri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@murali-shris @gkc @VJag