Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding at_repl to packages #338

Merged
merged 40 commits into from
Jun 28, 2023
Merged

feat: adding at_repl to packages #338

merged 40 commits into from
Jun 28, 2023

Conversation

Xlin123
Copy link
Member

@Xlin123 Xlin123 commented Jun 8, 2023

- What I did

  • Created a Dart REPL. Published it onto pub.dev with atsign org https://pub.dev/packages/at_repl
  • All of the instructions for installation/use are on pub.dev.
  • I retracted the latest version until the PR merges.

- Verify

Added more thorough testing to the project. Please let me know if I'm missing certain test cases.

- Description for the changelog

Created dart repl.

Xlin123 and others added 27 commits May 18, 2023 18:13
Co-authored-by: Jeremy Tubongbanua <JeremyTubongbanua@users.noreply.github.com>
- fix: Add '\n' when sending atProtocol command direct to the atServer
- fix: do not use readLineSync, as this freezes the entire Dart VM
- fix: simplified methods in lib/at_repl.dart, removing duplicated and unnecessary boilerplate
- feat: Add rootUrl as optional parameter to REPL constructor
- feat: removed the wait for an initial sync to complete
- style: ran dart format, fixed some lint warnings
- style: added additional lint rules; fixed some more lint warnings
@JeremyTubongbanua
Copy link
Member

JeremyTubongbanua commented Jun 11, 2023

After reading https://pub.dev/packages/at_repl I tried installing it via locally

This is how I installed it locally which worked for me

cd packages/at_repl
dart pub global activate .  --source path

The instructions on how to download it locally on pub.dev did not work for me.

@JeremyTubongbanua
Copy link
Member

I put in an incorrect atSign (that I do not have the keys to)

It did not read my keys

But it continued to put me in REPL

jeremytubongbanua@Jeremys-M2-Air ~ % at_repl -a @jeremy0 -r root.atsign.org:64 -v --no-enforceNamespace
Looking up secondary server address for @jeremy0 on root.atsign.org:64
Connecting...   Authentication failed: PathNotFoundException: Cannot open file, path = '/Users/jeremytubongbanua/.atsign/keys/@jeremy0_key.atKeys' (OS Error: No such file or directory, errno = 2)
Disconnected, atClient is null.
You don't need to include name spaces.
@jeremy0 scan
Unhandled exception:
Exception: AtClient is null for some reason...
#0      REPL.executeCommand (package:at_repl/src/at_repl.dart:42:7)
#1      main (file:///Users/jeremytubongbanua/GitHub/at_tools/packages/at_repl/bin/at_repl.dart:144:39)
<asynchronous suspension>

@JeremyTubongbanua
Copy link
Member

In /help Typo?

regex (e.g. _scan test@alice.*)

Should it be /scan not _scan ?

@Xlin123 Xlin123 marked this pull request as draft June 12, 2023 20:36
@Xlin123 Xlin123 marked this pull request as ready for review June 13, 2023 18:55
@Xlin123
Copy link
Member Author

Xlin123 commented Jun 13, 2023

there is a known bug related to this ticket
after that ticket is resolved, I'm planning to add at least a test for shared_keys.

image

@Xlin123 Xlin123 marked this pull request as draft June 19, 2023 02:34
@Xlin123
Copy link
Member Author

Xlin123 commented Jun 19, 2023

Need to wait until the at_client changes get pushed to pub.dev

@gkc
Copy link
Contributor

gkc commented Jun 19, 2023

Need to wait until the at_client changes get pushed to pub.dev

Why?

@Xlin123
Copy link
Member Author

Xlin123 commented Jun 19, 2023

I'm still getting the "Invalid or Corrupted Pad block" error for the shared_keys. I think it's fixed now, but it isn't in the latest version on pub so I'm just waiting.

Should I open the PR back up?

@gkc
Copy link
Contributor

gkc commented Jun 19, 2023

Can you test with the at_client_sdk trunk branch and verify the issue has been fixed please?

@gkc
Copy link
Contributor

gkc commented Jun 19, 2023

@Xlin123 Once you've verified that the issue has been fixed, please review & approve this PR so I can publish at_client v 3.0.62

@Xlin123 Xlin123 marked this pull request as ready for review June 23, 2023 03:13
@gkc
Copy link
Contributor

gkc commented Jun 28, 2023

Nice work @Xlin123

@gkc gkc merged commit 4d81a35 into trunk Jun 28, 2023
3 checks passed
@gkc gkc deleted the repl branch June 28, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants