Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated to latest core SDK packages; miscellaneous fixes, enhancements and doc improvements #101

Merged
merged 16 commits into from
Mar 23, 2023

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Mar 17, 2023

- What I did
Dependencies

  • Updated pubspec to use latest core SDK packages
    • Took up version 3.0.57 of at_client for bug fixes and encryption enhancements
    • Took up version 1.2.5 of at_onboarding_cli so the keys files go in the correct location
  • Updated pubspec to use latest versions of other packages

Bug fixes

  • fix: convert received notification key to lower-case, and compare with lower-case value 'privatekey'
  • fix: changed comparison for sshPublicKey also, to sshpublickey
  • docs: Added code comments explaining why the toLowerCase is now being done, and why we are now comparing with lower-case values

Lint

  • Eliminated most use of deprecated methods. (One exception: sync's onDone parameter)
  • Eliminated all other lint warnings
  • Fixed typos in code comments
  • docs: Fixed typos and format issues in README.md
  • Ran dart format on the codebase

fixes #100
fixes #102
fixes #103

chore: dart format
@gkc gkc requested a review from cconstab March 17, 2023 16:29
gkc added 3 commits March 17, 2023 18:41
docs: Added code comments explaining why the toLowerCase is now being done, and why we are now comparing with lower-case values
…edGuarded so that we can print the stack trace of any unhandled exceptions
@gkc gkc changed the title chore: Eliminated lint warnings, fixed typos, ran dart format fix: various fixes and enhancements to sshnpd and sshnp Mar 17, 2023
@gkc gkc changed the title fix: various fixes and enhancements to sshnpd and sshnp fix: updated to latest core SDK packages; miscellaneous fixes, enhancements and doc improvements Mar 17, 2023
gkc added 2 commits March 21, 2023 17:57
build: Take up version 3.0.57 of at_client
feat: Take up encryption enhancements from at_client 3.0.57
@gkc
Copy link
Contributor Author

gkc commented Mar 21, 2023

@cconstab pushed some more changes

  • build: Updated version in pubspec.yaml to 3.0.0
  • build: Take up version 3.0.57 of at_client for bug fixes and encryption enhancements
  • build: Take up version 1.2.5 of at_onboarding_cli so the keys files go in the correct location

If your testing on this branch goes OK (whenever you get a chance to do that) then this branch can be merged and we can publish release 3.0.0

Copy link
Member

@cconstab cconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extensive testing and a couple or minor log file changes and lower casing of the sshnp atKeys and we are good to go.. Thanks @gkc

@gkc gkc merged commit e80c0b1 into trunk Mar 23, 2023
@gkc gkc deleted the gkc-de-linting branch March 23, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants