feat: create slim version of sshnpd docker container that connects to hosts sshd #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpswan
requested changes
Feb 12, 2024
There was a problem hiding this comment.
It's good that we have build instructions in the Dockerfile, but how does somebody use this?
I think we need some extra README to explain why this is useful and how it can be used.
Also are there any tests we can run that will exercise the image and validate that it's doing what we expect?
| autoreconf | ||
| ./configure LIBS="-lpthread" "--with-ldflags=-static" "--prefix=$root" "--exec-prefix=$root" --with-privsep-user=nobody --with-privsep-path="$prefix/var/empty" "--with-ssl-dir=$root" | ||
| make | ||
| cd "$top" |
|
As mentioned in the PR the instructions will be coning to the docs site. |
|
@cpswan @JeremyTubongbanua I took a look at the existing tests and need some help adapting them to test this build. |
|
@cconstab I've got an overhaul of the e2e tests in the works which I will complete this week, will ensure this is covered also. |
cpswan
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Created a docker container that holds sshnpd srv and statically linked versions of ssh and ssh-keygen for x86/Arm65/ArmV7
- How I did it
Created Dockerfile that builds sshnpd and srv, wrote script that builds openssh and libs into static binaries.
Isolated bugs in the builds of openssh in Docker on Armv7
Added build to the existing GitHub docker build action
- How to verify it
Built manually and tested - to be documented on noports.com
running container using the --host and --user arguments on docker run to point the containers localhost to the hosts and mounting ~/ as /atsign in the container allows the container to provide access to the ssh daemon on the host.
- Description for the changelog
slim version of sshnpd docker container that connects to hosts sshd (typically 34mb as against 300mb for full container)