Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split INSTRUMENTNAME and isolate instruments from effectors #8

Closed
atsushieno opened this issue Sep 29, 2021 · 1 comment
Closed

split INSTRUMENTNAME and isolate instruments from effectors #8

atsushieno opened this issue Sep 29, 2021 · 1 comment

Comments

@atsushieno
Copy link
Owner

Currently when we reference audio graphs using INSTRUMENTNAME, we have to specify ALL the relevant plugins within the *.filtergraph file i.e. it specifies both an instrument and effectors. That means, ALL the tracks that reference the audio graph by INSTRUMENTNAME will share the identical set of effectors as well. For example, sfzz-ui-metal-gtx.filtergraph currently specifies kpp distruction effector, which would be very specific for songs that want to use it. We will end up creating *.filtergraphs for each, only to differentiate effector settings.

That's not ideal. We should be able to indicate the instrument and effects by any combinations to not bloat the filtergraphs.

Idea: use ';' to split instruments into multiple IDs and combine them for each track.

atsushieno added a commit that referenced this issue Oct 29, 2021
…MENTNAME.

context: #8

Audio-only graphs were not supported at all, so there is not a few lines of
changes to make it loadable.

Mars example now uses "SimpleReverb" https://github.com/szkkng/SimpleReverb
@atsushieno
Copy link
Owner Author

done at 1a427a0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant