Skip to content

Commit

Permalink
ResourceList request was never processed due to missing pending reque…
Browse files Browse the repository at this point in the history
…st record.
  • Loading branch information
atsushieno committed Mar 4, 2024
1 parent 46d9acc commit 898afc8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ class CommonRulesPropertyClient(private val device: MidiCIDevice, private val co
device.messenger.requestIdSerial++,
requestASCIIBytes
)
device.messenger.send(msg)
// it needs to be sent via this method otherwise we will fail to record it as a "pending request"
conn.propertyClient.sendGetPropertyData(msg)
}

override fun propertyValueUpdated(propertyId: String, data: List<Byte>) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ class PropertyExchangeHostFacadeTest {
// test get property
val conn = device1.connections[device2.muid]
assertNotNull(conn)
assertEquals(1, conn.propertyClient.properties.getMetadataList()!!.size, "client MetadataList size")

val client = conn.propertyClient

client.sendGetPropertyData(id)
Expand Down

0 comments on commit 898afc8

Please sign in to comment.