This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
[Feat] apply/sequenced group charts dep #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardlt
force-pushed
the
feat/apply/sequenced-group-charts-dep
branch
4 times, most recently
from
515977b
to
4131a41
Compare
gardlt
changed the title
gardlt
force-pushed
the
feat/apply/sequenced-group-charts-dep
branch
3 times, most recently
from
1d93c40
to
973195d
Compare
alanmeadows
reviewed
Jun 29, 2017
armada/handlers/armada.py
Outdated
| if self.wait: | ||
| if self.timeout: | ||
| chart_timeout = self.timeout | ||
| elif getattr(chart, 'timeout', None): |
There was a problem hiding this comment.
When would this path ever get activated -- a chart specific timeout? self.timeout has an oslo config default of 3600 so it would always be set?
Shouldn't this be:
if getattr(chart...)
chart_timeout = chart.timeout
else
chart_timeout = self.timeout
alanmeadows
suggested changes
Jun 29, 2017
gardlt
force-pushed
the
feat/apply/sequenced-group-charts-dep
branch
from
973195d
to
98da9fa
Compare
gardlt
force-pushed
the
feat/apply/sequenced-group-charts-dep
branch
from
98da9fa
to
8b0c727
Compare
* added new structure to the armada yaml
gardlt
force-pushed
the
feat/apply/sequenced-group-charts-dep
branch
from
8b0c727
to
55c3a0f
Compare
|
This looks like a fine way to organize chart groups. I would really like to see a "group wait" functionality in the future -- I'll make an issue. |
gardlt
pushed a commit
to gardlt/armada
that referenced
this pull request
Jul 3, 2017
…up-charts-dep [Feat] apply/sequenced group charts dep
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?:
We want to bring in sequenced deployments to the armada files
What issue does this pull request address?: Fixes #61
Notes for reviewers to consider:
Specific reviewers for pull request:
@theyer @drewwalters96