Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser vs browsers - confusing param names #36

Closed
jakub-g opened this issue Jun 17, 2013 · 0 comments
Closed

browser vs browsers - confusing param names #36

jakub-g opened this issue Jun 17, 2013 · 0 comments

Comments

@jakub-g
Copy link
Collaborator

jakub-g commented Jun 17, 2013

browser param is used to indicate which executables to run.
browsers param is used to indicate which physical browsers to expect to connect.

Those names are confusing (too similar) and should be changed.
jakub-g added a commit to jakub-g/attester that referenced this issue Jul 30, 2013
@jakub-g
Refactor confusing browser/browsers options
ead35cc 
Renamed `browser` to `run-browser` and `browsers` to `required-browsers`.

Close attester#36.
jakub-g added a commit to jakub-g/attester that referenced this issue Jul 31, 2013
@jakub-g
Refactor confusing browser/browsers options
989167d 
Renamed `browser` to `run-browser` and `browsers` to `required-browsers`.

Close attester#36.
jakub-g added a commit to jakub-g/attester that referenced this issue Aug 1, 2013
@jakub-g
Refactor confusing browser/browsers options
d863824 
Renamed `browser` to `run-browser` to avoid confusion with `browsers`
specifying required browsers for the campaign.

Close attester#36.
jakub-g added a commit to jakub-g/attester that referenced this issue Aug 1, 2013
@jakub-g
Refactor confusing browser/browsers options
519a7e8 
Renamed `browser` to `run-browser` to avoid confusion with `browsers`
specifying required browsers for the campaign.

Close attester#36.
jakub-g added a commit to jakub-g/attester that referenced this issue Sep 26, 2013
@jakub-g
Refactor confusing browser/browsers options
13bd04d 
Renamed `browser` to `run-browser` to avoid confusion with `browsers`
specifying required browsers for the campaign.

Close attester#36.
jakub-g added a commit to jakub-g/attester that referenced this issue Oct 8, 2013
@jakub-g
Refactor confusing browser/browsers options
f4ed02f 
Renamed `browser` to `run-browser` to avoid confusion with `browsers`
specifying required browsers for the campaign.

Close attester#36.
jakub-g added a commit to jakub-g/attester that referenced this issue Oct 10, 2014
@jakub-g
[breaks-compat] Refactor confusing browser/browsers options
46b6001 
Renamed `browser` to `run-browser` to avoid confusion with `browsers`
specifying required browsers for the campaign.

Close attester#36.
jakub-g added a commit to jakub-g/attester that referenced this issue Oct 10, 2014
@jakub-g
[breaks-compat] Refactor confusing browser/browsers options
6251ee6 
Renamed `browser` to `run-browser` to avoid confusion with `browsers`
specifying required browsers for the campaign.

Close attester#36.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakub-g