Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable number of PhantomJS instances from the includer's package.j... #8

Closed
wants to merge 1 commit into from

Conversation

jakub-g
Copy link
Collaborator

@jakub-g jakub-g commented Jan 18, 2013

...son

After this commit, one who depends on attester in his "scripts" part of
package.json, can additionally put in that file the following:

 "config":{"phantomjsInstances":2}

to specify the number of PhantomJS instances (instead of passing it via
command line), but as the added benefit, the actual user who npm install'ed
his package, could type:

 npm config set somePackage:phantomjsInstances 8

to take advantage of his multi-core machine.

This setting is taken into account only if there was no
--phantomjs-instances passed from the command line when invoking attester.

…e.json

After this commit, one who depends on attester in his "scripts" part of
package.json, can additionally put in that file the following:

 "config":{"attesterThreads":2}

to specify the number of PhantomJS instances (instead of passing it via
command line), but as the added benefit, the actual user who npm install'ed
his package, could type:

 npm config set somePackage:attesterThreads 8

to take advantage of his multi-core machine.

This setting is taken into account only if there was no
--phantomjs-instances passed from the command line when invoking attester.
@divdavem
Copy link
Contributor

Integrated in 12ecafc with the following name for the configuration parameter: phantomjsInstances (instead of attesterThreads)

@divdavem divdavem closed this Jan 22, 2013
@jakub-g jakub-g deleted the cmdLineThreads branch January 24, 2013 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants