Remove references to "BUG 11" in the code since #11 has been fixed.

attic-labs · Jul 15, 2015 · 0ef19f9 · 0ef19f9
1 parent c364850
commit 0ef19f9
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 4 deletions.
diff --git a/datas/datastore.go b/datas/datastore.go
@@ -25,7 +25,6 @@ func newDataStoreInternal(cs chunks.ChunkStore, rt chunks.RootTracker, rc *rootC
 	if (rootRef == ref.Ref{}) {
 		roots = NewRootSet()
 	} else {
-		// BUG 11: This reads the entire database into memory. Whoopsie.
 		roots = RootSetFromVal(types.MustReadValue(rootRef, cs).(types.Set))
 	}
 	return DataStore{

diff --git a/datas/root_cache.go b/datas/root_cache.go
@@ -34,7 +34,6 @@ func (cache *rootCache) Update(rootsRef ref.Ref) {
 		return
 	}
 
-	// BUG 11: This is super-inefficient with eager ReadValue and no caching
 	rootSet := RootSet{types.MustReadValue(rootsRef, cache.source).(types.Set)}
 	rootSet.Iter(func(commit Root) (stop bool) {
 		cache.updateFromCommit(commit)

diff --git a/dataset/dataset.go b/dataset/dataset.go
@@ -71,9 +71,7 @@ func (rt *datasetRootTracker) UpdateRoot(current, last ref.Ref) bool {
 		return false
 	}
 
-	// BUG 11: Sucks to have to read the dataset root here in order to commit.
 	datasetRoot := types.MustReadValue(current, rt.rootStore)
-
 	rt.rootStore = mgmt.CommitDatasets(rt.rootStore, mgmt.SetDatasetRoot(mgmt.GetDatasets(rt.rootStore), rt.datasetID, datasetRoot))
 	return true
 }