Skip to content
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.

Lazy loading/decoding of data #11

Closed
rafaelweinstein opened this issue Jun 25, 2015 · 5 comments
Closed

Lazy loading/decoding of data #11

rafaelweinstein opened this issue Jun 25, 2015 · 5 comments

Comments

@rafaelweinstein
Copy link
Contributor

We currently eagerly load all values recursively.

While this is sometimes what you want, it frequently isn't. For example right now, when someone asks DataStore for the current roots, we will read the entire database into memory.

It requires some thought as to where to put the gradual expansion.
@rafaelweinstein
Copy link
Contributor Author

See references to this bug (BUG 11) in the code for known places where this is a problem.

@aboodman aboodman self-assigned this Jul 7, 2015
@aboodman
Copy link
Contributor

aboodman commented Jul 7, 2015

I'll take this.

@aboodman aboodman mentioned this issue Jul 8, 2015
Closed
@aboodman aboodman changed the title We eagerly read all refs during decoding Lazy loading/decoding of data Jul 9, 2015
@aboodman aboodman mentioned this issue Jul 10, 2015
Closed
@aboodman
Copy link
Contributor

As of c4537d8, this is working for Lists. Tomorrow, sets and maps.

aboodman added a commit that referenced this issue Jul 10, 2015
@aboodman
Incremental loading for sets.
daac3ef 
Issue #11
@aboodman aboodman assigned ghost and unassigned aboodman Jul 13, 2015
@aboodman
Copy link
Contributor

@rafael-atticlabs volunteered to rescue me from the last bit of this (Map). yay.

@ghost
Copy link

ghost commented Jul 13, 2015

Support for maps added in 8297bae

@ghost ghost closed this as completed Jul 13, 2015
aboodman added a commit that referenced this issue Jul 15, 2015
@aboodman
Remove references to "BUG 11" in the code since #11 has been fixed.
0ef19f9
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aboodman @rafaelweinstein