Skip to content
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.

Encoding needs to be aware of lazy-loading #23

Closed
aboodman opened this issue Jul 10, 2015 · 1 comment
Closed

Encoding needs to be aware of lazy-loading #23

aboodman opened this issue Jul 10, 2015 · 1 comment
Assignees

Comments

@aboodman
Copy link
Contributor

Even after #11 is implemented, we still have to do more work in the encoding path, otherwise we end up re-expanding everything when trying to save. For example:

v, _ := ReadValue(<bigval>, cs)
v = v.Append(Int32(42))
// At this point,we've only read one ref

// This line ends up reading all the refs because it walks the tree in order to serialize :-/.
r, _ := WriteValue(v, cs)
@aboodman
Copy link
Contributor Author

lgtm!

arv referenced this issue in arv/noms-old Jul 16, 2015
Keep using futures in the encoding

Fixes #23
@arv arv closed this as completed in #41 Jul 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants