This repository has been archived by the owner on Aug 28, 2021. It is now read-only.
Encoding needs to be aware of lazy-loading #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add test too |
| var getRef = func(v Value) ref.Ref { | ||
| type RefGetter func(v Value) ref.Ref | ||
|
|
||
| var getRefOverride RefGetter |
There was a problem hiding this comment.
Since RefGetter type is not referred to anywhere else:
a) it can be private (refGetter)
b) you don't even need it - just define the type inline - var getRefOverride func(v Value) ref.Ref
arv
force-pushed
the
encode-skip-deref
branch
2 times, most recently
from
f233460
to
026cd8d
Compare
|
PTAL |
| count := 0 | ||
| getRef = func(val Value) ref.Ref { | ||
| getRefOverride = func(val Value) ref.Ref { |
There was a problem hiding this comment.
Oh, this is actually better.
|
PTAL I updated the tests |
Keep using futures in the encoding Fixes #23
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep using futures in the encoding
Fixes #23