Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-45: Enable Pressing Enter Key to Search #46

Closed
wants to merge 3 commits into from
Closed

issue-45: Enable Pressing Enter Key to Search #46

wants to merge 3 commits into from

Conversation

brandon-bogan
Copy link
Contributor

Added an onKeyDown prop to the input component that calls doKeyPress, which checks if the key is Enter or not, and calls onSearch if it is (copied from the implementation of SearchBar)

luigivaldez
luigivaldez requested changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@luigivaldez luigivaldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual change is fine. But can you create a new branch and do a new pull request with only the. change to NavbarSearch.js and not all of the styleguide stuff?

Thanks!

@brandon-bogan
Copy link
Contributor Author

@luigivaldez - Per your comment, I've copied over the change to NavbarSearch in a new branch directly on SUIT and submitted a new PR for that branch. See PR #171

Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigivaldez luigivaldez luigivaldez requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandon-bogan @luigivaldez @bogan27 @klk1010