issue-98: Enable optimistic update for tags #99
Conversation
Add configurable Max Resubmits property to Searcher
Syncing with latest commits from @attivio/suit
…backs to the Search.updateRealtimeField function
There was a problem hiding this comment.
Hey Brandon, can you make these changes on your tag_autocomplete branch instead. This way, you've created a second pull request instead of just augmenting the first one and it's not really possible to reconcile them both together... (If you commit changes to a branch that's already the source of a pull request, the changes are added to the PR automatically—GitHub can even let each of us see the changes since the previous review...)
Thanks!!
Done! See brandon-bogan@8a4810b for the merge into the |
| @@ -719,8 +719,8 @@ class Searcher extends React.Component<SearcherDefaultProps, SearcherProps, Sear | |||
| /** | |||
| * Update the list of tags for the given document. | |||
| */ | |||
| updateTags(tags: Array<string>, docId: string): Promise<any> { | |||
| return this.search.updateRealtimeField(docId, FieldNames.TAGS, tags); | |||
| updateTags(tags: Array<string>, docId: string, onCompletion: () => void, onError: (error: string) => void): Promise<any> { | |||
There was a problem hiding this comment.
I might be missing something, but I don't see a place where updateTags is used. This change isn't harmful, but I'd expect to see any place using updateTags to be updated as well.
There was a problem hiding this comment.
nm, I see it being used through context and you already updated that.
|
If this is being included in PR#97, can this PR be closed? |
Search.js's updateRealTimeField function and Searcher's updateTags function now take onCompletion and onError callbacks, which get called once the update has been sent in but before the commit finishes.
SearchResultTags creates the callbacks, and knows to show the update to the user and stop loading/spinning once one of these is called.