Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About Declarations and Definitions of khash #40

Closed
kevin-xu opened this issue Nov 14, 2014 · 4 comments
Closed

About Declarations and Definitions of khash #40

kevin-xu opened this issue Nov 14, 2014 · 4 comments

Comments

@kevin-xu
Copy link

KHASH_DECLARE declares with extern, but KHASH_INIT is replaced with KHASH_INIT2(SCOPE = static kh_inline), SCOPE is always static. I want to know how to use KHASH_DECLARE. It looks like a bug.

Thanks to you.
@lh3
Copy link
Collaborator

lh3 commented Nov 14, 2014

Only use KHASH_INIT2

@kevin-xu
Copy link
Author

So users should define an extern version of KHASH_SET_INIT_STR and etc, if they want to use KHASH_DECLARE??

@lh3
Copy link
Collaborator

lh3 commented Nov 30, 2014

Yes. Unfortunately.

@lh3 lh3 closed this as completed Nov 30, 2014
@kevin-xu
Copy link
Author

kevin-xu commented Dec 3, 2014

I think it's a bad idea. Obviously, there're some good ways to refine it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lh3 @kevin-xu