Add 'd' 64-bit floating point number type tag #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attwad
reviewed
Jun 10, 2018
pythonosc/parsing/osc_types.py
Outdated
| dgram[start_index:start_index + _DOUBLE_DGRAM_LEN])[0], | ||
| start_index + _DOUBLE_DGRAM_LEN) | ||
| except (struct.error, TypeError) as e: | ||
| raise ParseError('Could not parse datagram %s' % e) |
There was a problem hiding this comment.
Please use raise ParseError('Could not parse datagram {}'.format(e))
for consistency
attwad
reviewed
Jun 10, 2018
|
|
||
| def test_get_double(self): | ||
| cases = { | ||
| b'\x00\x00\x00\x00\x00\x00\x00\x00': (0.0, 8), |
There was a problem hiding this comment.
add negative number test case please
|
Thanks for the PR! Will bump the minor version number after this is merged. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55, refs #42.
Comments welcome.
p.s. Any plans for bumping version number?