Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show preview auto #1804

Merged
merged 2 commits into from
Apr 18, 2024
Merged

feat: show preview auto #1804

merged 2 commits into from
Apr 18, 2024

Conversation

tessus
Copy link
Contributor

@tessus tessus commented Mar 1, 2024

This change introduces a new config option show_preview_auto = true|false with true being the default.

I wanted to originally replace the current boolean option show_preview with an option that takes also the value auto. But this would've been a breaking change and should be done when the config/settings are updated to the new format. I am more than happy to create another PR then.

/ref Show preview only if command longer than terminal width

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I appreciate the work on the tests 🙏

@ellie ellie merged commit 176eae0 into atuinsh:main Apr 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants