Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daemon): add support for daemon on windows #2014

Merged
merged 14 commits into from
May 13, 2024

Conversation

YummyOreo
Copy link
Contributor

@YummyOreo YummyOreo commented May 11, 2024

Add support for the daemon on windows using tcp.

fixes #2011

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but nothing major! Thanks for the work 🚀

crates/atuin-client/src/settings.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
crates/atuin-client/src/settings.rs Outdated Show resolved Hide resolved
crates/atuin-daemon/src/server.rs Outdated Show resolved Hide resolved
crates/atuin-daemon/src/client.rs Outdated Show resolved Hide resolved
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you! :shipit:

@ellie ellie merged commit ce67e52 into atuinsh:main May 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: atuin does not compile on windows since daemon was added
2 participants