Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shellcheck on all shell scripts #64

Closed
ellie opened this issue May 8, 2021 · 0 comments · Fixed by #97
Closed

Use shellcheck on all shell scripts #64

ellie opened this issue May 8, 2021 · 0 comments · Fixed by #97

Comments

@ellie
Copy link
Member

ellie commented May 8, 2021

And also add a CI step that uses it!

There's been a couple of install script issues that could have been totally avoided.

I'd also like to make sure the init scripts are correct
yuvipanda added a commit to yuvipanda/atuin that referenced this issue May 9, 2021
@yuvipanda
Run shellcheck on bash file
4d2943d 
Ref atuinsh#64
yuvipanda added a commit to yuvipanda/atuin that referenced this issue May 9, 2021
@yuvipanda
Run shellcheck on bash file
7327b8f 
Ref atuinsh#64
@yuvipanda yuvipanda mentioned this issue May 9, 2021
Merged
ellie pushed a commit that referenced this issue May 9, 2021
@yuvipanda
Run shellcheck on bash file (#81)
c69f6ee 
Ref #64
@ismith ismith mentioned this issue May 9, 2021
Merged
@ellie ellie closed this as completed in #97 May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

run shellcheck ismith/atuin
1 participant
@ellie