Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run shellcheck on bash file #81

Merged
merged 1 commit into from
May 9, 2021
Merged

Run shellcheck on bash file #81

merged 1 commit into from
May 9, 2021

Conversation

yuvipanda
Copy link
Contributor

Ref #64

@yuvipanda
Copy link
Contributor Author

shellcheck doesn't support zsh unfortunately

@ellie
Copy link
Member

ellie commented May 9, 2021

shellcheck doesn't support zsh unfortunately

that's a shame!

Thank you for this one 🚀

@ellie ellie merged commit c69f6ee into atuinsh:main May 9, 2021
@ismith
Copy link
Contributor

ismith commented May 9, 2021

Shellcheck claims to support zsh, or at least https://github.com/ludeeus/action-shellcheck includes it in their list of suffixes - I'll take a pass at it.

@ismith
Copy link
Contributor

ismith commented May 9, 2021

... I stand corrected :sadpanda:

In src/shell/atuin.zsh line 1:
#!/bin/zsh
^-- SC1071: ShellCheck only supports sh/bash/dash/ksh scripts. Sorry!

(Shellcheck will run on the file if it lacks a shellbang, but ... I guess it's assuming it's bash? So I'm going to exclude it from files checked by the shellcheck action.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants