Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding UX: Installation guide #43

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

Flightkick
Copy link
Contributor

Mostly restructuring and rephrasing, see commit messages for details.

Upgraded Astro/Starlight dependencies in order to get <Aside> support, which allows displaying warnings by using MDX components.

Breaking changes: Please do note that some headings were changed. This may cause page anchors to break. I don't expect this to be much of an issue, as the doc is quite compact anyway.

Needed to upgrade astro/starlight in order to get <Aside> support.
- Restructure sections and make use of starlight framework components to minimize cognitive load.
- Fix typo's, restructure and/or rephrase sentences to minimize ambiguity.
- Avoid skipping heading levels.
- Use shell instead of none/sh/bash blocks in order to support syntax highlighting.
@Flightkick
Copy link
Contributor Author

Linking atuinsh/atuin#1798

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! Thank you

@ellie ellie merged commit 1508783 into atuinsh:main Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants