4888: Undefined Index warnings during IMS CC import #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 19, 2011 20:10
…ameters in startElement()
| @@ -26,19 +26,19 @@ if ($_GET['tile']) { | |||
| <html lang="<?php echo $myLang->getCode(); ?>"> | |||
| <head> | |||
| <title><?php echo _AT($lang_variable); ?></title> | |||
| <?php if ($_GET['frame']) { ?> | |||
| <?php if (array_key_exists('frame', $_GET)) { ?> | |||
There was a problem hiding this comment.
Line 18 uses "isset($_GET['tile']) && $_GET['tile']" to check the presence of the $_GET value while this line uses another approach. Should we make it consistent by using one way through? The same comment applies to line 36, 41.
BTW, I personally likes the line 18 way better. :)
There was a problem hiding this comment.
The difference is that isset() will return false for array keys that have their value set to NULL whereas array_key_exists() only checks that the key exists.
That said, I'm struggling to recall the reason I used these styles of code. I think it was because I believed or saw that some of the GET variables may be NULL e.g. "/home/prog.php" rather than "/home/prog.php?done"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see http://atutor.ca/atutor/mantis/view.php?id=4888