Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added queryToStruct helper function #197

Merged
merged 2 commits into from
Mar 20, 2014
Merged

Conversation

sneiland
Copy link
Contributor

Added an additional helper function to convert a query result set with a single record to a struct as opposed to an array of length one with a struct.

Added an additional helper function to convert a query result set with a single record to a struct as opposed to an array of length one with a struct.
@atuttle
Copy link
Owner

atuttle commented Mar 19, 2014

Looks really good, thanks. Just a few notes.

  • You'll probably want to move this to a feature branch and re-submit the pull request from that branch. This is because pull requests are tied to a branch, so when you push more commits to your master branch, they will appear as part of this pull request. (Or a future pull request will appear to also have these changes, too)
  • Move the var statement above the first if statement, for CF8 compatibility.

Looking forward to merging this in! :)

@sneiland
Copy link
Contributor Author

And done. Can you tell that I don't work with git very often lol

atuttle pushed a commit that referenced this pull request Mar 20, 2014
Added queryToStruct helper function
@atuttle atuttle merged commit fe1ad28 into atuttle:master Mar 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants