Add Disc Number support #139
Conversation
Although ID3 and a number of tagging schemes do not support disc numbers - Disc numbers are can be an integral part of tagging for multi-disc albums, especially Classical music. This PR adds Disc number support to audacious-plugins - there is a complementary PR to audacious adding support there. This implements Feature #603 Signed-off-by: Andrew Thornton <art27@cantab.net>
|
As in audacious-media-player/audacious#63, the translation changes should be omitted. I noticed just one trivial whitespace error. Other than that, the changes looks good to me. |
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Sorry for the delayed response. I've removed the po changes.
Oh? I can't see it - do you want to write a comment on the line that has the error so I can fix it? Is there anything else I need to do to get this in? |
|
I haven't found the time to test it but want to do so this weekend. The code looks good to me. The whitespace issue mentioned by John is probably the if-statement in Thanks @zeripath for the contributions. 👍 |
Signed-off-by: Andrew Thornton <art27@cantab.net>
aha! The final bracket appeared to have gained a preceding whitespace - not sure how I did that. I've removed that.
Cools. Hope it works for you. |
| @@ -151,6 +151,8 @@ static void read_comment (vorbis_comment * comment, Tuple & tuple) | |||
| tuple.set_int (Tuple::Track, atoi (tmps)); | |||
| if ((tmps = vorbis_comment_query (comment, "DATE", 0))) | |||
| tuple.set_int (Tuple::Year, atoi (tmps)); | |||
| if ((tmps = vorbis_comment_query (comment, "DISCNUMBER", 0))) | |||
| tuple.set_int (Tuple::Disc, atoi (tmps)); | |||
There was a problem hiding this comment.
@zeripath: The if still has a wrong indentation.
Signed-off-by: Andrew Thornton <art27@cantab.net>
Although ID3 and a number of tagging schemes do not support disc numbers - Disc numbers are can be an integral part of tagging for multi-disc albums, especially Classical music.
This PR adds Disc number support to audacious-plugins - there is a complementary PR to audacious adding support there. (audacious-media-player/audacious#63)
This implements Feature #603