Add Disc Number support #63
Conversation
Although ID3 and a number of tagging schemes do not support disc numbers - Disc numbers are can be an integral part of tagging for multi-disc albums, especially Classical music. This PR adds Disc number support to audacious - there will be a complementary PR to audacious-plugins adding support there. Signed-off-by: Andrew Thornton <art27@cantab.net>
|
All the changes in the The rest looks good to me from a quick scan-through; I have not tested it. There are some unnecessary blank lines added that I'd prefer not to see. @radioactiveman are you able to give this a review? |
|
Sorry for the delayed response. I've removed the po changes. |
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Merged as 4a61c81 with slight modifications:
Thanks again @zeripath for contributing this feature. |
|
@jlindgren90: audacious-plugins 4.3.2 as potential next release has to compile against audacious (core) 4.3.0, right? This is no longer the case because of the new disc number enum value. How should we handle this? We could also release directly Audacious 4.4.0 as easy solution. I would wait though for the new background music plugin to be ready. Related question: Do we also need to increase the libaudcore version? |
|
Typically yes, a feature like this (with new libaudcore API) would go into a minor release like 4.4.0, while 4.3.2 would be limited to bug fixes only. If you have time & interest in following up on the background music plugin review, please feel free. I have been busy with other projects lately. |
|
libaudcore would also receive a minor version bump for the new enum value. |
Although ID3 and a number of tagging schemes do not support disc numbers - Disc numbers are can be an integral part of tagging for multi-disc albums, especially Classical music.
This PR adds Disc number support to audacious - there is a complementary PR to audacious-plugins adding support there. (audacious-media-player/audacious-plugins#139)
This implements Feature #603