Add missing enum value. #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jlindgren90: How would you name the enum value?
@madpilot78: I think we should use this new enum value instead of -1 in |
You're definitely right. I'll wait for a decision on what it should be called and then update the review accordingly. |
|
I vote for |
|
Updated according to suggestions. |
jlindgren90
requested changes
Jun 30, 2023
New versions of the clang compiler have strict checks for enum values. The value "-1" is returned as a last resort from to_vfs_seek_type() as a VFSSeekType. Replace usage of `-1` with the new enum name.
|
Merged with slight changes. Thanks! |
x7upLime
pushed a commit
to x7upLime/gentoo
that referenced
this pull request
Jul 20, 2023
backported from: audacious-media-player/audacious#64 Closes: https://bugs.gentoo.org/896412 Signed-off-by: x7upLime <andrew@andrewdomain.com>
x7upLime
pushed a commit
to x7upLime/gentoo
that referenced
this pull request
Jul 21, 2023
backported from: audacious-media-player/audacious#64 Closes: https://bugs.gentoo.org/896412 Signed-off-by: Andrei Corduneanu <andrew@andrewdomain.com>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jul 22, 2023
backported from: audacious-media-player/audacious#64 Closes: https://bugs.gentoo.org/896412 Signed-off-by: Andrei Corduneanu <andrew@andrewdomain.com> Closes: #31980 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New versions of the clang compiler have strict checks for enum values.
The value "-1" is returned as a last resort from to_vfs_seek_type() as a VFSSeekType.
I added the value with a name that makes sense for such usage.
For context:
This is necessary to make audacious compile on latest FreeBSD head (future FreeBSD 14.0) which includes clang version 16.
I already added thsi as a local patch to the FreeBSD ports tree: freebsd/freebsd-ports@72610ec