Identically-named effects cannot be differentiated in the Select Command dialog in Macro editing

[petersampsonaudacity]

Describe the bug
Identically-named effects cannot be differentiated in the Select Command dialog in Macro editing

Originally logged on Bugzilla as P3 1709
https://bugzilla.audacityteam.org/show_bug.cgi?id=1709

To Reproduce
Steps to reproduce the behavior:

1. Install any two identically-named effects of different type (e.g. "Limiter" in nyquist and LV2)
2. Manage Macros
3. Add a new Macro or select an existing Macro
4. Click Insert - in the Select Command dialog there will be two entries with the same name (e.g. "Limiter")
5. Click either entry and then click "Edit Parameters"
6. Observe: Regardless of which entry you click, the same dialog is shown

Expected behavior
Similarly named effects should be differeentiated

Screenshots
None

Additional information (please complete the following information):

• OS: all OS
• Version: Reported on 2.2.0 - but still extant with 3.0.4 / a;pha 3.1.0

Additional context
Bill wrote on the Bugzilla thread:

On Mac:

1. download the free mda VST pack http://mda.smartelectronix.com/effects.htm
2. install "mda Limiter.vst" in ~/Library/Audio/Plug-ins/VST
3. start Audacity
4. in Effects Preferences, choose Group by Type, then OK
5. in the Plug-ins Manager, enable the mda Limiter effect
6. import or create some audio and select it
7. Effect > VST > Limiter: you get the nyquist Limiter effect

If you don't do step 4, then you get a cascading menu at Effect > Limiter where you can choose one or the other by full path.

This is similar to choosing an effect in Chains where it is done by name rather than by full path.

BTW, on my Mac (10.11.4) all the mda VST effects crash Audacity. Just a heads-up in case you were thinking of actually using the mda Limiter.

and later he wrote:

On Mac:

1. download the free mda VST pack http://mda.smartelectronix.com/effects.htm
2. install "mda Limiter.vst" in ~/Library/Audio/Plug-ins/VST
3. start Audacity
4. in the Plug-ins Manager, enable the mda Limiter effect
5. File > Chains > Edit Chains, Add a new chain and click Insert
   Note that in the "Select Command" dialog there are two entries for "Limiter"
6. Select the first "Limiter" in the list and Edit Parameters

• you get the Nyquist Limiter

7. Select the second "Limiter" in the list and Edit Parameters

• you get the Nyquist Limiter

I don't think this is a matter of "LV2 effects are hidden by like-named LADSPA effects in Chain editing" as the title currently says, since it happens with identically-named effects of any stripe.

Changing the bug title to:
Identically-named effects cannot be differentiated in the Select Command dialog in chain editing

Although, as shown in comment 2, there is also a problem with identically-named effect in the Effect menu.

Also changing Component from "LV2" to "User Interface" since this seems to be an issue of choosing effects by name rather than an issue with any particular effect type.