Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar layout is corrupted after an upgrade from 3.1.3 to 3.2.0 (with no reset) #2919

Closed
petersampsonaudacity opened this issue May 12, 2022 · 4 comments
Labels
bug An error, undesired behaviour, or missed functionality Design / UX Bugs, enhancement requests and tasks a designer should look at P2 High priority regression Bug is a regression against previous version
Milestone

Comments

@petersampsonaudacity
Copy link

petersampsonaudacity commented May 12, 2022

Proposed action: automatically reset toolbars on upgrade

Describe the bug
If the user upgrades from 3.1.3 to 3.20 without making a reset as part of the update the the Toolbar layout is corrupted.
a) the new wider window size is not used (Audacity remembers and reuses the user's previous window size from 3.1.3 or earlier)
b) The Edit Toolbar incorporates a large empty space, unnecessarily more than doubling its width
c) The Tools Toolbar incorporates a small empty space unnecessarily increasing its width by 50%
d) The Play-at-Speed Toolbar remains in the top tooldock area
e) The Device Toolbar remains visible
f) as a result of all the above, the Upper tooldock area occupies 6 lines rather than the 3 one should get with 3.2.0 thereby reducing the space available for a user's tracks.

To Reproduce
Steps to reproduce the behavior:

  1. Purge the audacity folder to get default OOTB factory settings
  2. launch 3.1.3
  3. Observe Toolbar layout - see Screenshot 1
  4. Close 3.1.3
  5. Launch 3.2.0
  6. Observe corrupted toolbar layout as per bug description above- See screenshot 2
  7. View > Toolbars > Reset Toolbars
  8. Observe: Upper tooldock occupies 4 lines (window is not wide enough - see Screenshot 3
  9. Observe: Lower Tooldock occupies 3 lines not 2 (as the window is not wide enough to enable the Play-at-Speed Toolbar to st alongside the Timer Toolbar
  10. Observe: the Device Toolbar is disabled/hidden - expected behavior
  11. Tools > Reset Configuration
  12. Observe: Tooldock layout is as expected for 3.2.0 (that which you get if you purge Audacity settings and then launch 3.2.0) - see screenshot 4

Actual behavior
Corrupted Tooldock areas

Expected behavior
a) As a minimum the new 3.2.0 window width size should be used
b) Probably a full (perhaps optional) reset to get the default 3.2.0 Toolbars layout (as this is not just a minor change)

Screenshots

1) default 3.1.3 Toolbar layout

image

2) 3.2.0 after upgrade from 3.1.3 with no reset

image

3) 3.2.0 after Reset Toolbars

image

3) 3.2.0 after Reset Toolbars

image

Additional information (please complete the following information):

  • OS: Windows 10 - but assume all OS
  • Version: Audacity 3.2.0

Additional context
The simple no reset upgrade (screenshot 2) just looks messy and bad - and thus really should be fixed for 3.2.0 release.

This is effectively a regression as upgrades with previous versions did NOT cause a corrupted messy toolbar layout.

@petersampsonaudacity petersampsonaudacity added bug An error, undesired behaviour, or missed functionality Design / UX Bugs, enhancement requests and tasks a designer should look at regression Bug is a regression against previous version labels May 12, 2022
@LWinterberg
Copy link
Member

There was an idea earlier to include this info in a "what's new" popup (#2718), but now I'm thinking that we really should just reset the toolbars on upgrade

@petersampsonaudacity
Copy link
Author

Testing on my Macbook Pro macOS Monterey 12.3.1

I confirm I see the same behaviors on Mac

@petersampsonaudacity
Copy link
Author

petersampsonaudacity commented May 17, 2022

@LWinterberg This gets even worse when you upgrade from 3.1.3 to the Branch 3.2.0 build with the new cogwheel toolbar
image

@LWinterberg LWinterberg added the P2 High priority label May 17, 2022
@LWinterberg LWinterberg added this to the Audacity 3.2 milestone May 17, 2022
@LWinterberg LWinterberg mentioned this issue May 18, 2022
6 tasks
@LWinterberg
Copy link
Member

closing in favor of #3479

@LWinterberg LWinterberg closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error, undesired behaviour, or missed functionality Design / UX Bugs, enhancement requests and tasks a designer should look at P2 High priority regression Bug is a regression against previous version
Projects
None yet
Development

No branches or pull requests

2 participants