Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when clicking Debug in Nyquist plug-in #3232

Closed
dozzzzer opened this issue Jul 14, 2022 · 6 comments · Fixed by #3266
Closed

Crash when clicking Debug in Nyquist plug-in #3232

dozzzzer opened this issue Jul 14, 2022 · 6 comments · Fixed by #3266
Assignees
@crsib @dozzzzer
Labels
bug An error, undesired behaviour, or missed functionality crash / freeze catastrophic errors P1 Highest level priority (ship blocker / must fix) regression Bug is a regression against previous version

Comments

@dozzzzer
Copy link
Contributor

dozzzzer commented Jul 14, 2022 •
edited by petersampsonaudacity

Describe the bug
Crash when clicking Debug in Risset Drum (or Rhythm Track) generator dialog

To Reproduce
Steps to reproduce the behavior:

  1. Go to Generate > Risset Drum (or Rhythm Track)
  2. Click Debug
  3. Observe

Actual behavior
Audacity crashes: https://sentry.audacityteam.org/share/issue/4136da944009482cb59b5f51b1bec04c/

Additional information (please complete the following information):

  • OS: MacOS 12.2.1
  • Version: latest master build
@dozzzzer dozzzzer added bug An error, undesired behaviour, or missed functionality P1 Highest level priority (ship blocker / must fix) crash / freeze catastrophic errors Generators labels Jul 14, 2022
@petersampsonaudacity petersampsonaudacity added the regression Bug is a regression against previous version label Jul 14, 2022
@petersampsonaudacity
Copy link

Confirmed on W10 - regression on 3.1.3

@petersampsonaudacity
Copy link

Using the Debug button in Rhythm Track also crashes Audacity

@petersampsonaudacity petersampsonaudacity changed the title Crash when clicking Debug in Risset Drum generator dialog Crash when clicking Debug in Risset Drum (or Rhythm track) generator dialog Jul 14, 2022
@SteveDaulton
Copy link
Member

SteveDaulton commented Jul 14, 2022 •
edited

The bug appears to affect all Nyquist plug-ins, not just ";type generate".
If any Nyquist plug-in is run with the Debug button, Audacity crashes.

@SteveDaulton SteveDaulton changed the title Crash when clicking Debug in Risset Drum (or Rhythm track) generator dialog Crash when clicking Debug in Nyquist plug-in Jul 14, 2022
@crsib crsib self-assigned this Jul 20, 2022
@crsib crsib mentioned this issue Jul 20, 2022
Merged
6 tasks
@petersampsonaudacity
Copy link

Testing on W10 with latest alpha master audacity-win-3.2.0-alpha-20220721+db0b7f8-x64-msvc2022

I confirm this works OK on W10

@dozzzzer dozzzzer self-assigned this Jul 21, 2022
@SteveDaulton
Copy link
Member

Works here too (Xubuntu 20.04).

@dozzzzer
Copy link
Contributor Author

Verified on MacOS 12.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crsib crsib

@dozzzzer dozzzzer

Labels
bug An error, undesired behaviour, or missed functionality crash / freeze catastrophic errors P1 Highest level priority (ship blocker / must fix) regression Bug is a regression against previous version
Projects
No open projects
Kanban board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forward OnClose event of the EffectHostUI to the Effect crsib/audacity
4 participants
@crsib @SteveDaulton @petersampsonaudacity @dozzzzer