Regular Interval Labels crashes Audacity

[petersampsonaudacity]

Describe the bug
Regular Interval Labels crashes Audacity.

This is a regression on 3.1.3

To Reproduce
Steps to reproduce the behavior:

1. Generate 2 minutes of silence
2. Tools > Regular Interval Labels
3. Use the default settings and press OK
4. Observe: Audacity crashes silently with no crash report and no "phone-home"

Actual behavior
Audacity crashes

Expected behavior
10 labels to be created fro 0-1:30

Screenshots
None

Additional information (please complete the following information):

• OS: Windows 10
• Version: Audacity 3.2.0 alpha master

Additional context
Flagging @SteveDaulton - but this would not appear to be an issue with Regular Interval Labels itself but a problem with Audacity itself. If I run RIL in 3.1.3 but choose the "3.2.0" version of RIL then the the RIL works ...

[SteveDaulton]

If I run RIL in 3.1.3 but choose the "3.2.0" version of RIL then the the RIL works ...

That's surprising. Regular Interval Labels (equalabel.ny) was last changed in October 2018.

[dozzzzer]

I was able to reproduce the crash on Windows 11 machine using the STRs by @petersampsonaudacity, while on MacOS it works just fine.

[SteveDaulton]

Testing with commit id 193321 on Xubuntu, I can reproduce the issue by following the steps to reproduce as written.

The crash seems to occur immediately after a call to wxWindowBase::Destroy()

[SteveDaulton]

The problem seems to be from EffectUIHost::OnClose()

[SteveDaulton]

Here's the problem 96e8d0b

[crsib]

I will take a look, @SteveDaulton. This commit is a fix for a different crash

[petersampsonaudacity]

Testing on W10 with latest alpha master audacity-win-3.2.0-alpha-20220721+db0b7f8-x64-msvc2022

I confirm this works OK on W10

[SteveDaulton]

@crsib You got it this time.

FWIW, the reason that the debug window always opens for this plug-in is because Nyquist only has one return value (in this case it's labels), but I also wanted to let the user know what the plug-in had done. (Nyquist plug-in GUIs are pretty basic, so the UX is not always as clear as we would like).

Normally a Nyquist plug-in displays messages by returning a string (or a number), which Audacity then displays in a message window, but Nyquist can't return both labels and a string. Forcing the debug window to open works around this limitation as Nyquist can write to the debug output at any time, not just on exit.

[dozzzzer]

Verified on MacOS 12.2.1 and Windows 11.