Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle for sharing visibility #3884

Closed
AnitaBats opened this issue Nov 1, 2022 · 6 comments · Fixed by #4013
Closed

Toggle for sharing visibility #3884

AnitaBats opened this issue Nov 1, 2022 · 6 comments · Fixed by #4013
Assignees
@crsib @dozzzzer
Labels
Task Tasks for the team, typically in conjunction with sprints and projects
Milestone
Audacity 3.2.3

Comments

@AnitaBats
Copy link

No description provided.

@AnitaBats AnitaBats added this to the Audacity 3.2.3 milestone Nov 1, 2022
@DilsonsPickles
Copy link
Collaborator

Figma project file can be found here.

@DavidBailes
Copy link
Collaborator

DavidBailes commented Nov 30, 2022 •
edited
Loading

Figma project file can be found here.

@DilsonsPickles Can this file be made viewable by anyone?

@crsib crsib mentioned this issue Dec 2, 2022
Merged
6 tasks
@crsib crsib linked a pull request Dec 2, 2022 that will close this issue
Allow setting the visibility of the shared audio #4013
Merged
6 tasks
@dozzzzer dozzzzer self-assigned this Dec 7, 2022
@dozzzzer
Copy link
Contributor

dozzzzer commented Dec 8, 2022

The share audio dialog doesn't remember the previously selected option, i.e. every time a user tries to share audio, they end up seeing the "Public" option selected by default, not the option they selected when uploading last time.

image

@crsib
Copy link
Contributor

crsib commented Dec 8, 2022

But should it? @DilsonsPickles

@DilsonsPickles
Copy link
Collaborator

It should yes, this was included in the spec document as seen below:

image

@crsib
Copy link
Contributor

crsib commented Dec 8, 2022

Sorry, missed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crsib crsib

@dozzzzer dozzzzer

Labels
Task Tasks for the team, typically in conjunction with sprints and projects
Projects
[AU3] Main board
Status: Done
Milestone
Audacity 3.2.3
Development

Successfully merging a pull request may close this issue.

Allow setting the visibility of the shared audio crsib/audacity
5 participants
@crsib @DavidBailes @dozzzzer @AnitaBats @DilsonsPickles