Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: in AAC export, setting the bit rate quality by typing fails to work (previous setting is used) #4320

Open
petersampsonaudacity opened this issue Feb 15, 2023 · 3 comments
Assignees
Labels
bug An error, undesired behaviour, or missed functionality import-export macOS Bugs only affecting macOS systems P3 Medium Priority

Comments

@petersampsonaudacity
Copy link

petersampsonaudacity commented Feb 15, 2023

Bug description

On Mac in the MP4(AAC) export dialog setting the bit rate quality by typing fails to work (previous setting is used)
a) if I use the up/down arrows to set the required bit-rate Audacity uses that bit-rate
b) if I type a number into the bit-rate field, the Audacity ignores that "setting" and instead uses the previously used setting

The worst of this is, is that the user is extremely likely to be opaquely unaware of this inappropriate, unwanted, export quality setting.

This does NOT happen on Windows, only on Mac (I do not know the behavior on Linux)

Steps to reproduce

  1. get a 3 minute stereo song
  2. File > Export > Export Audio
  3. choose M4A(AAC)... in the Save as Type field
  4. Change the bit rate to 200 kbps by using the up/down arrows
  5. Export the AAC file
  6. Observe: the exported file is exported at 202kbps (I use iTunes to assess this)
  7. File > Export > Export Audio
  8. AAC is still active
  9. change the bit rate to 320 kbps by typing "320"
  10. Export the AAC file
  11. Observe: the file is exported at 202 kbps not 320/321

Expected behavior

As with Windows the user's typed numerical bit rate should be used by Audacity for the export.

Actual behavior

When the user changes the bit rate by typing a value, Audacity ignores this and instead uses the last previously used value.

Audacity Version

3.2.4 and 3.3.0 latest alpha

Operating system

macOS 12.6.3 Monterey

Additional context

Discovered while testing #4309

@petersampsonaudacity petersampsonaudacity added bug An error, undesired behaviour, or missed functionality macOS Bugs only affecting macOS systems import-export labels Feb 15, 2023
@petersampsonaudacity petersampsonaudacity changed the title Mac: in AAC export setting the bitrate quality by typing fails to work (previous setting is used) Mac: in AAC export, setting the bitrate quality by typing fails to work (previous setting is used) Feb 15, 2023
@petersampsonaudacity petersampsonaudacity changed the title Mac: in AAC export, setting the bitrate quality by typing fails to work (previous setting is used) Mac: in AAC export, setting the bit rate quality by typing fails to work (previous setting is used) Feb 21, 2023
@Ryan-Miller-Audacity Ryan-Miller-Audacity self-assigned this Feb 24, 2023
@Ryan-Miller-Audacity
Copy link

I can reproduce this issue as described on MacOS, not on windows as mentioned in the summary. The previous setting is being used when a bit rate is typed into the field on the export dialog screen for AAC export.

@Ryan-Miller-Audacity Ryan-Miller-Audacity added the P2 High priority label Feb 24, 2023
@LWinterberg LWinterberg added P3 Medium Priority and removed P2 High priority labels Feb 24, 2023
@LWinterberg LWinterberg added this to the Audacity 3.x / Future milestone Feb 24, 2023
@petersampsonaudacity
Copy link
Author

petersampsonaudacity commented Aug 24, 2023

@chinakov @dozzzzer @LWinterberg

Testing on macOS 12.6.8 Monterey with latest 3.4.0 alpha: audacity-macOS-3.4.0-alpha-20230823+2dd7948-x86_64

This no longer appears to be an issue:
a) at steps 5-6 the requested 200kbps file exports as 197kbps
b) at steps10-11 the requested 320kbps file exports as 263kbps

This indicates that the issue reported in this ticket is no longer extant in the latest master 3.4.0 alpha as the over-typing at step 9 is "honored" by Audacity as it exports at a higher bitrate than the previous bitrate.

I suspect that this isl most likely due to the new Export dialog changes that @vsverchinsky worked on recently and are now in the 3.4.0 alpha builds.

Accordingly I think that this issue can be closed.


Residual issue

BUT from observing the two results one can see that there remains the residual issue that the user's requested bitrate is not actually honored for the AAC export.

See: M4A(AAC) Export does not honor the user's quality settings for bit rates below 196kbps in the export dialog #4309

I have not re-tested #4309 - but it now looks like the 320kbps request is no longer honored either.

@petersampsonaudacity
Copy link
Author

And see also this old (now closed) issue:

The slider setting value for AAC/MP4 export is not honored by Audacity - and the slider cannot make precise settings #1818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error, undesired behaviour, or missed functionality import-export macOS Bugs only affecting macOS systems P3 Medium Priority
Projects
None yet
Development

No branches or pull requests

3 participants