Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQ in a macro fails when applied to files #5604

Closed
petersampsonaudacity opened this issue Nov 13, 2023 · 3 comments · Fixed by #5608
Closed

EQ in a macro fails when applied to files #5604

petersampsonaudacity opened this issue Nov 13, 2023 · 3 comments · Fixed by #5608
Assignees
Labels
bug An error, undesired behaviour, or missed functionality Effects (EGATs) Effects, Generators, Analyzers and Tools macros / scripting Bugs related to macros and scripts regression Bug is a regression against previous version

Comments

@petersampsonaudacity
Copy link

petersampsonaudacity commented Nov 13, 2023

Bug description

When either EQ effect is used in a macro fails with an error message when applied to files - it works fine if you apply it to audio in a project.

This is a regression on 3.3.3 where the simple macro runs on files with no error message.

Steps to reproduce

  1. create a simple Macro with Filter Curve EQ in it (or Graphic EQ)
  2. Apply it to files
  3. Observe error message

I tested further and added an Export to WAV command and no files or macro-output folder were created.

Expected behavior

This macro should work with no error message

Actual behavior

Step 1
image

Step 3
image

Audacity Version

3.4.1 and 3.4.2 latest Beta (in fact all 3.4.x)

Operating system

Windows 10 - but assume all OS

Additional context

Originally reported by a Forum user:
New bug in 3.4.1. Had to revert to 3.4.0
https://forum.audacityteam.org/t/new-bug-in-3-4-1-had-to-revert-to-3-4-0/89756

@petersampsonaudacity petersampsonaudacity added bug An error, undesired behaviour, or missed functionality regression Bug is a regression against previous version macros / scripting Bugs related to macros and scripts Effects (EGATs) Effects, Generators, Analyzers and Tools labels Nov 13, 2023
@dozzzzer dozzzzer added this to the Audacity 3.4.2 milestone Nov 13, 2023
@saintmatthieu saintmatthieu self-assigned this Nov 13, 2023
@dozzzzer
Copy link
Contributor

Bisects to 618d61e

@saintmatthieu
Copy link
Contributor

Bisects to 618d61e

Thanks @dozzzzer ; but that means it's already present in 3.4.0, which contradicts that forum user which @petersampsonaudacity reported he said "New bug in 3.4.1. Had to revert to 3.4.0"

Anyway, I think I can at least provide a fix for this github issue's very description.

@chinakov
Copy link
Contributor

Tested. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error, undesired behaviour, or missed functionality Effects (EGATs) Effects, Generators, Analyzers and Tools macros / scripting Bugs related to macros and scripts regression Bug is a regression against previous version
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants