Clicking again the "Presets & Settings" button in an effect dialog won't close the dropdown menu (Windows)

[dozzzzer]

Steps to reproduce

1. Open up any effect's dialog either from the realtime effects panel or from the main Effect/Generate menu
2. Click "Presets & Settings"
3. Observe: the dropdown menu expands
4. Click "Presets & Settings" again

Expected behavior

The dropdown menu gets closed

Actual behavior

The dropdown menu remains open

Audacity Version

current master / alpha / nightly build

Operating system

Windows 10 & 11

Additional context

This goes all the way back to at least 2.4

[petersampsonaudacity]

@dozzzzer I do not believe that this is an issue - for me it works as expected ...

In fact it dates back to 2.1.1 when presets for effects were first introduced - but notice that back then (and indeed in 2.4.2 even) the presets were invoked with a Manage button rather than a Presets & Settings button:

And note that a second click on the Manage button never did close the dropdown presets menu.

---

However, having said that as a user I do not really expect a second press on Manage or Presets&Settings to close the menu.

The Presets dropdown menu can readily be dismissed by clicking anywhere else in the Audacity window - and even by clicking outside the Audacity window.

So for me the UI is working properly in this regard and I really don't think this is a bug (or design flaw) to be corrected.

[dozzzzer]

I really don't think this is a bug (or design flaw) to be corrected

It definitely should be corrected one way or another, simply for the sake of consistency across platforms. Currently, both on macOS and Linux, clicking again the Presets & Settings does close the menu.

[LWinterberg]

Note that we don't need consistency across platforms, but consistency within platforms. This means stuff like #5963 is something we should do to get in line with the host OS (mac: Cancel/OK, windows: OK/Cancel), rather than getting the buttons to be in the same order across all OSes.

As for consistency within Audacity on Windows:

• Clicking again on true dropdowns (like the one in the time signature) closes them
• Clicking again on the fake dropdown we use for the snapping thing closes it.
• Clicking again on the NumericTextControl... is actually impossible as the options overlap the control.
• Clicking again on the Audio Setup button reopens it.
• Clicking again on the timeline gear reopens it.
• Clicking again on the Preferenes > Shortcuts > Defaults button reopens it (though the context menu tends to overlay).