-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H110i (and possibly other hid devices) miss features #65
Comments
Feel free to code the features; I do have a HID based CorsairLink, but don't have the time to work on it. I can test using mine. I'd like to keep any function returns for error codes. And keep the code based towards the Asetek Protocol; that means the HID functions should match the Asetek protocol. |
There are functions that I don't know if asetek protocol supports (fan count, temp sensor count etc). I will be implementing these as do-nothing functions for asetek. For example, temp sensor count function will always return 3 for asetek (3 is the value used now in main.c). Is this OK? |
No, If you want you can run the commands for fan count in existing functions and fail fast. But don't create additional/new functions. We could discuss changing the driver interface, but for now I want to keep it static until I can asses better ways of doing what we need for both HID and Asetek. |
It can't work that way. For example, in main.c you have a fixed iteration loop for temperature sensors (ii < 3) but HID api has a way to report the number of temperature sensors. I have almost completed my code, I have made the following changes in driver API.
Current output of my code for example:
And another one with different values for fan (Fan 0 fixed pwm set to 140, Fan 1 fixed RPM set to 1380)
And this is the help which shows what else is implemented (most code copied from your legacy branch)
Looking forward for your comments PS: For all the above function changes, I only implement the HID part, Asetek part stays compatible but non-implemented. |
I'm actually fine with the changes. I just wish Asetek had a way to report back the fan/etc counts. |
@malakudi Would it be possible to provide the necessary changes in order to be able to change the pump rpm for the H110i? Seems you made it work for your device. Thanks! |
@malakudi Is there a testing branch available anywhere? I noticed none of that code is in your fork and I'd like to help best I can. |
The problem is I have a big diff file of 32KB of changes and want to break it to specific patches in order to have a description of what I did. Will try to do that in the next days (I was quite busy the last 2 months). |
OK it wasn't that time consuming after all. I broke patch in 5 sections and created pull request. |
Patch has been merged in. |
I am working with my H110i and current code lucks some features that H110i and possibly other Corsair HID devices support. Features include:
I am willing to code the above features if original author agrees. I don't know if there are plans of implementing this on his side, or if specific implementation guidelines are needed. Feel free to comment.
The text was updated successfully, but these errors were encountered: