Add public APIs for 2PC #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This scopes the module to make it sort correctly. Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
There are several similar fields between contexts; this makes the implementations closer by consistently ordering them. Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
TwoPhaseCommitContext is the public context struct. It is a superset of the CoordinatorContext and ParticipantContext. From/TryFrom are implemented to convert between the contexts. Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
TwoPhaseCommitAction is a superset of CoordinatorAction and ParticipantAction and part of the public API. TryFrom/From implemented to convert between them. Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
Makes CoordinatorMessage and ParticipantMessage private. Also changes the error type used by CoordinatorMessage to InvalidStateError. Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
TwoPhaseCommitEvent is a superset of CoordinatorEvent and ParticpantEvent. Implements From/TryFrom to convert between them. Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
This is the primary public API of the algorithm. This is a superset of ParticipantAlgorithm and CoordinatorAlgorithm designed to make it easier to use. Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
vaporos
requested review from
agunde406,
peterschwarz and
rbuysse
as code owners
peterschwarz
approved these changes
Apr 18, 2022
agunde406
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.