Support for Gnome 40

[aunetx]

The extension still does not support Gnome 40:

• no GTK4 preferences windows
• no idea how it looks in it, as overview/dash changed

[RandomnessRobin]

Hoping to see this extension work in gnome 40 soon. Not sure of that will happen. But i am hoping it does.

[aunetx]

I hope too, and of course it will happen!
For the moment, those are the bugs I have:

• settings need to be ported to GTK4 (should be OK)
• blur needs to be restored to the top panel after leaving the overview (it is currently not the case in gnome 40)
• proper animations should be added to the panel
• overview should be blurred: for this, I need to be able to add an image as a background of the overview (so that I can blur it after, which is easy one the image is there). It would look something like this

[aunetx]

Panel is done, overview should be OK soon. However, I have a problem with the preferences (I can't open any preference of extension in my testing VM, so I don't know if mine is working...)

[aunetx]

Nearly good, it works really better than for gnome 3.38 actually :)
I just need to make sure settings work, and it's good for gnome 40!

To test it, install from the branch "gnome-40"

[Saren-Arterius]

Will the new design be like this? https://www.reddit.com/r/gnome/comments/mtd057/in_love_with_this/

[aunetx]

Exactly like this yes :)

[Saren-Arterius]

That would be holy! Glad to hear! Thanks

[Saren-Arterius]

@aunetx I see the panel blur working, but overview's background is still plain color instead of blurred wallpaper. Am I missing something? Or is it gnome theme dependent? Thanks

[aunetx]

@Saren-Arterius are you sure that you switched to the "gnome-40" branch?

[Saren-Arterius]

Sure 在 2021年4月19日週一 19:37，Aurélien Hamy ***@***.***> 寫道：

…

@Saren-Arterius <https://github.com/Saren-Arterius> are you sure that you switched to the "gnome-40" branch? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFYHN4TOLL6XPKKAZDZDO3TJQIWTANCNFSM4Z47ZJZA> .

[aunetx]

If you want to try with this version (you can install it with gnome-extensions install blur-my-shell@aunetx.zip --force):
blur-my-shell@aunetx.zip

[Saren-Arterius]

I installed your zip. It is working now. I had to untick and tick overview however. I guess leftover perf caused this.

By the way, lockscreen's blur is affected regardless of the tick.

[aunetx]

Thanks for the report!

I had the overview issue too, I don't know why... I guess it is because my extension grabs the wallpaper before it is created, so it gives something weird after login

I did not try lockscreen for the moment, I have a lot of issues with my VMs...
The "no artifacts" option is broken too, because of a depreciation of the paint signal which I used a lot...

[not-a-dev-stein]

If you want to try with this version (you can install it with gnome-extensions install blur-my-shell@aunetx.zip --force):
blur-my-shell@aunetx.zip

Just tried it and faced quite a load of issues. First, messing with the tick boxes for lockscreen and dash changed nothing, the second monitor´s overview wasn´t blurred, the selection between the levels of quality were all checked and still faced some artifacts, specially with the clock. I´m aware it its still not prime time for it on GNOME 40 though, can barely wait for it to be 100% ready.

[aunetx]

Thanks for trying @not-a-dev-stein ! I'm sorry I will do it quickly (nearly 1am, time to go to bed) :)

If you want to test with the latest github version (from branch gnome-40, then doing make pkg and taking the package from there, or just make install), maybe some bugs are fixed now: normally the artifacts selection is better (although selecting the "no artifacts" option will make the extension crash on restart), and the settings are maybe better connected...

But to be honest, I still need to take some more time to figure out all the remaining bugs, and I did not test either dash or lockscreen for the moment.

And thanks for reminding me of the second monitor bug, I forgot to implement it when I rewrote the overview blur! At least this one will be easy to catch tomorrow :)

[500InternalError]

If you want to try with this version (you can install it with gnome-extensions install blur-my-shell@aunetx.zip --force):
blur-my-shell@aunetx.zip

The extension randomly fails with something like "background_parent.getparent() is null" in log.Changing this.background_parent.get_parent().remove_child(this.background_parent); to this.background_parent.remove_child(this.background_parent); in panel.js fixes the issue(at least for me).
Also the extension doesn't live happy with dash to dock beta with an error "actor is null".No idea about how to fix this.

[500InternalError]

Btw can you please add a dedicate switch to control whether to blur the dash to dock?Switching the dash option on makes the dock looks like a transparent one in overview.So I think switching the dash option off while enabling dash to dock blur might be better.

Great thanks for your work on this,can't wait for it to be completed

[aunetx]

@500InternalError could you give me the error log? And did this error happen when you disabled the extension only, or on loading?
I don't really understand why it would bug this way, it seems weird... but gnome is weird anyway :)

And I don't understand your request sorry! Would you want to be able to blur the dash-to-dock dock, but not remove the blur when in overview?
If yes, I could try to add an option for this of course! And for the moment (as I will not work on it now), you can comment lines 138 and 142 of extension.js (this._dash_to_dock_blur.hide(); and this._dash_to_dock_blur.show();)

[500InternalError]

@500InternalError could you give me the error log? And did this error happen when you disabled the extension only, or on loading?
I don't really understand why it would bug this way, it seems weird... but gnome is weird anyway :)

And I don't understand your request sorry! Would you want to be able to blur the dash-to-dock dock, but not remove the blur when in overview?
If yes, I could try to add an option for this of course! And for the moment (as I will not work on it now), you can comment lines 138 and 142 of extension.js (this._dash_to_dock_blur.hide(); and this._dash_to_dock_blur.show();)

Sorry for my poor description. What I want to say is that blurring both overview and dash makes it look like this

feels kind of weird.So I think blurring the dash-to-dock but removing the blur in overview might be better

[500InternalError]

@aunetx Oh I found the log:

When enabling blur for dash:

[Blur my Shell] blurring dash
[Blur my Shell] searching for dash
[Blur my Shell] dash to dock found, blurring it
clutter_actor_get_child_at_index: assertion 'index_ <= self->priv->n_children' failed
JS ERROR: TypeError: actor is null
connect@/home/zhenzhe/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/connections.js:32:18
blur_dash_from@/home/zhenzhe/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/dash_to_dock.js:118:26
try_blur@/home/zhenzhe/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/dash_to_dock.js:80:35
blur_existing_dashes/<@/home/zhenzhe/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/dash_to_dock.js:69:18
blur_existing_dashes@/home/zhenzhe/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/dash_to_dock.js:68:37
enable@/home/zhenzhe/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/dash_to_dock.js:61:14
_connect_to_settings/<@/home/zhenzhe/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/extension.js:82:41

When disabling the extension:
[Blur my Shell] disabling extension...
[Blur my Shell] removing blur from top panel
JS ERROR: Extension blur-my-shell@aunetx: TypeError: this.background_parent.get_parent() is null
disable@/home/zhenzhe/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/panel.js:117:32
disable@/home/zhenzhe/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/extension.js:59:26
_callExtensionDisable@resource:///org/gnome/shell/ui/extensionSystem.js:108:32
_onEnabledExtensionsChanged/<@resource:///org/gnome/shell/ui/extensionSystem.js:499:45
_onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:499:24
createCheckedMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:516:46
disableExtension@resource:///org/gnome/shell/ui/extensionSystem.js:209:29
DisableExtension@resource:///org/gnome/shell/ui/shellDBus.js:314:38
_handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:310:38

[500InternalError]

When disabling the extension:
[Blur my Shell] disabling extension...
[Blur my Shell] removing blur from top panel

I guess the extension crashes because it tries to remove blur from panel even if it hadn't blur it(I didn't enable the blur for panel before)

[carlocastoldi]

I guess the extension crashes because it tries to remove blur from panel even if it hadn't blur it(I didn't enable the blur for panel before)

that is indeed the problem.
Commenting out the following line fixes for me:

blur-my-shell/src/extension.js

Line 60 in b4c941a

this._panel_blur.disable();

[aunetx]

Ok, I understand why it bugged. Do you use dash-to-dock?
I still not support this extension with gnome 40, and did not test it either...

[carlocastoldi]

I do not.
I use no extensions that changes the bottom panel in the overview

[RandomnessRobin]

I use dash to dock. But that extension in itself has things not working like icon sizing and opacity. But i mean the blur would be coming from your extension and not the dock so I don't know.

[500InternalError]

Oh, the dash_to_dock.js file misled me😂

[aunetx]

To be honest I feel kind of lost... I can't even distinguish bugs between them :/

[aunetx]

Oh man I just understood... I forgot to turn my brain on this morning sorry :)
Just like @500InternalError said, I disable the blur eventhough it does not exist... Will fix this asap

[aunetx]

That should be fixed in last commit (the disabling crash), could you test it and tell me?
I will try to add support for dash-to-dock soon

[RandomnessRobin]

Will try it when I get home in a few hours 2 or 3 and post about it here.

[carlocastoldi]

That should be fixed in last commit (the disabling crash), could you test it and tell me?
I will try to add support for dash-to-dock soon

that does indeed fix it! Thank you ^^

[aunetx]

Added support for dash-to-dock, so no error on enabling either :)

[aunetx]

Support for gnome 40 is complete, apart from sparse bugs (and of course #31, but I will investigate this separately)
Please reopen an issue if there is any other bug! :)

[carlocastoldi]

one small thing I might want to report is that after restarting the shell, dash opacity is not taken into account. It's full opaque.
I actually need to move the slider a little to have it properly set

[aunetx]

@carlocastoldi with dash-to-dock? I noticed something similar, but it should normally go away either within 3 seconds (as I settled up a timer to remove it due to a race with dash-to-dock), or when you change workspace

If not, please open another issue so I can keep track of this more easily!

[carlocastoldi]

I'm using the default dock.
I'll have to try the extension out for a little longer to see if what you are saying applies to me as well.
If not, I will open a new issue. Thanks ^^

[RandomnessRobin]

So the blur on the dash to dock makes the outer shape rectangle. I think someone mentioned but not sure. At least it works. Is disabled Dash to dock for now.

Also do see some artifacts when hovering over the items in the top panel but that might be normal.

[aunetx]

@carlocastoldi okay sorry, so this is definitely a bug (if you don't use dash to Dock) :)
If you open another issue it is perfect, and I will try to see what could cause this

[aunetx]

@RandomnessRobin yes, sadly I can't make rounded blur for the moment so the dash is a rectangle... Honestly it's the main reason why I don't use it anymore ^^

And the artifacts are "normal" (because of a gnome bug), but I will try to resolve this very quickly :)

[500InternalError]

Great the fix works. Thanks :)

[aunetx]

Cool, thanks a lot for trying :)

[RandomnessRobin]

Yes i think part of the reason why Gnome doesn't want to make the dock visible in the home screen is cause they don't want to be similar to Mac OS even tho it kinda is a least a little bit

[FDgajju]

i was update blur my shell after that blur my shell not working and there are error