-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Gnome 40 #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a look through these changes, from an extension reviewers perspective everything looks good!
Thanks a lot, do you think it is a good idea to wait for #31 to be resolved before merging this? |
@CorvetteCole I pushed this to extensions.gnome.org, and the support for dash-to-dock seemed good enough to merge this pull request :) |
I approved the extension update! I think I'll rebase my branch on to a new branch called application-blur or something. About the vfunc, I remember being told about that and trying to figure it out but I got stuck in the past. I'm going to take a look at it again, but it seems like some dark voodoo witchcraft to me |
Thanks a lot, that's really cool to be able to update the extension so quickly :) For the vfunc, I think I kind of understand the principle, but I really don't know how to implement it... For the moment I will add an option to have static blur for the top panel instead of dynamic blur, so there is no more artifact (and it does not change a lot of things, excepted if the use uses something like hide-my-topbar, but that's okay for the moment) |
See #24 for the issue
To this moment, the only big issue that remains is #31, but the extension is stable on gnome 40 if this option is temporarily disabled.