Fix mime type #20
Merged
Fix mime type #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @adynemo, and thank you very very much for the time you spent understanding and improving this! I tried this and it actually seems to work, that's great thank you! I merge this right now and this will be included in next update :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello ! 馃檪
This patch fixes #13
After several searches, the xdg-settings bug is still not resolved: https://gitlab.freedesktop.org/xdg/xdg-utils/-/issues/180
And finally, I don't know if update electron version could solve anything.
As explain here lbryio/lbry-desktop#5617 the bug appears when we call
setAsDefaultProtocolClienton Linux. There is the concerned lines on xdg-utils issue.Signal has change the production name and remove the dash from the desktop file
signal-desktop.desktoptosignal.desktopbut for some app, like deezer-linux, it seems to not work.So, I've chosen the LBRY way that avoid the call to this function if the platform is
linux. As deezer-linux is only for linux, I don't put the condition, but we can.I tested with the deb build and all works (start app, login via browser, listen music, etc).