-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for PHP 7.2, 7.3 and 7.4 #15
Conversation
Hey @kenjis , Thank you for the PR. As far as I know we were restricting the php version changes. So not sure this can be merged in that sense. But my take is this can be merged for php has moved a lot to 8.x . And I don't know if there will be another 3.x for Aura framework. I will leave the decision to pmjones. |
@pmjones @harikt @koriym But this is for PHP 7.x. So it should be merged into 4.x. |
4.x is created. Let me know if you need anything else. |
@pmjones @harikt @koriym In my local environment, phpunit testing passed: kenji:~/work/aura/Aura.Project_Kernel (3.x)$ /usr/local/opt/php\@7.2/bin/php vendor/bin/phpunit
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.
........S 9 / 9 (100%)
Time: 116 ms, Memory: 4.00 MB
OK, but incomplete, skipped, or risky tests!
Tests: 9, Assertions: 9, Skipped: 1.
kenji:~/work/aura/Aura.Project_Kernel (3.x)$ /usr/local/opt/php\@7.3/bin/php vendor/bin/phpunit
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.
........S 9 / 9 (100%)
Time: 59 ms, Memory: 4.00 MB
OK, but incomplete, skipped, or risky tests!
Tests: 9, Assertions: 9, Skipped: 1.
kenji:~/work/aura/Aura.Project_Kernel (3.x)$ /usr/local/opt/php\@7.4/bin/php vendor/bin/phpunit
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.
........S 9 / 9 (100%)
Time: 53 ms, Memory: 4.00 MB
OK, but incomplete, skipped, or risky tests!
Tests: 9, Assertions: 9, Skipped: 1. What shall we do? |
kenji:~/work/aura/Aura.Project_Kernel (3.x)$ /usr/local/opt/php\@8.0/bin/php vendor/bin/phpunit
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.
........S 9 / 9 (100%)
Time: 65 ms, Memory: 4.00 MB
OK, but incomplete, skipped, or risky tests!
Tests: 9, Assertions: 9, Skipped: 1. |
I can look into the test issues in this weekend. You can merge the branches in 4.x for now. pmjones has already approved the travis.com , but due to some reason the builds are not ready. |
phpunit 7 can't be installed on php8.
I will update to phpunit 8.x. Because phpunit 8 requires php 7.2 or later and supports php8. |
I have updated the github workflow. You can try again. |
@kenjis if this works you can make the necessary changes to all other repos also. |
FYI : I have created #18 for testing. You can see the phpunit it complains is due to wrong code. So all seems well. |
You can see the build. update the .github/actions/php.yml with the php version you need. |
@harikt Thanks! #15 (comment) |
Please refer composer.json and .github/workflows/php.yml for other repos you want the ci. I am moving on. |
Fixes issue #13
Includes #14