added getSegment method to Segment class to return the entire segment at once

[epoplive]

No description provided.

[harikt]

are you trying to get all the values from the Segment?

And I am not in favour of having the name getSegment inside the Segment itself. May be getValues or even we can alter the get method.

ie when no key is there return the session

Aura.Session/src/Segment.php

Lines 64 to 70 in 79c69da

	public function get($key, $alt = null)
	{
	$this->resumeSession();
	return isset($_SESSION[$this->name][$key])
	? $_SESSION[$this->name][$key]
	: $alt;
	}

Also this is another BC break.

[epoplive]

Yes, I need to get all of the values for the segment. I'm not really big on the name either, I thought of getValues but didn't really feel like that conveys the purpose, and getAllValues() or getEntireSegment() didn't seem particularly great. Open to suggestions, just need this functionality.

I spoke with pmjones earlier on IRC, and he prefers to not modify the existing methods, and even so modifying the existing method to take a null for the first param becomes ugly if one chooses a default besides null.

And again, adding new functionality is not breaking backwards compatibility. This is not legacy software...perhaps you thought you were looking at the 1.x branch?

[epoplive]

talked with pmjones, he's going to fork a 3.x branch so I can start making pull requests against that. Problem solved for everyone it sounds like.