Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router-lite): various overloads for the load method #1642

Merged
merged 9 commits into from
Jan 14, 2023

Conversation

Sayan751
Copy link
Member

Pull Request

📖 Description

This PR fixes the support for couple Router#load overloads.

  • Viewport name with component class.
  • Hierarchical viewport instruction with route-id as component.
  • Promise as component for the load method. Typical use-case: import('./view-model').

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

⏭ Next Steps

@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Merging #1642 (6cbb8b4) into master (473441b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1642      +/-   ##
==========================================
+ Coverage   87.73%   87.76%   +0.02%     
==========================================
  Files         240      240              
  Lines       22167    22168       +1     
  Branches     5005     5007       +2     
==========================================
+ Hits        19448    19455       +7     
+ Misses       2719     2713       -6     
Impacted Files Coverage Δ
packages/router-lite/src/instructions.ts 88.26% <ø> (+2.26%) ⬆️
packages/router-lite/src/router.ts 93.20% <ø> (ø)
packages/router-lite/src/route-tree.ts 81.38% <100.00%> (+0.71%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Sayan751 Sayan751 added this to the v2.0-beta milestone Jan 14, 2023
@Sayan751 Sayan751 merged commit fad763e into master Jan 14, 2023
@Sayan751 Sayan751 deleted the topic/load-viewport-instruction-vp-name branch January 14, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant