feat(convention): rewrite runtime-html decorators #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1960 +/- ##
==========================================
- Coverage 88.62% 88.62% -0.01%
==========================================
Files 272 272
Lines 22825 22823 -2
Branches 5292 5292
==========================================
- Hits 20229 20226 -3
- Misses 2596 2597 +1 ☔ View full report in Codecov by Sentry. |
Sayan751
changed the title
|
@CollinHerber Do these changes cover most of your use-cases? |
Yeah only one I think might be missing is @Inject |
|
Question, are we going to switch to #1939 in future for conventions code rewrite? Not sure whether it covers all the use cases. |
And @CustomElement |
|
@CollinHerber The resource decorators such as custom element, attribute etc. are already taken care of. I'll try to do something for the |
CollinHerber
reviewed
May 5, 2024
CollinHerber
approved these changes
May 5, 2024
3cp
approved these changes
May 5, 2024
|
@CollinHerber you can test it out with the latest dev version, thanks everyone, nice work 👍 |
This was referenced May 11, 2024
AureliaEffect
pushed a commit
that referenced
this pull request
May 11, 2024
2.0.0-beta.17 (2024-05-11) **BREAKING CHANGES:** * **template:** auto infer binding expression when empty (#1963) ([3359939](3359939)) Previously only the expression of binding to element bindables get auto inferred, now it's expanded to all bindings with `.bind`/`.to-view`/`.from-view`/`.two-way`/`.one-time` Examples: ```html <div some-prop.bind=""> means <div some-prop.bind="someProp"> <div some-prop.bind> means <div some-prop.bind="someProp"> <div some-prop.one-time> means <div some-prop.one-time="someProp"> ... ``` * **convention:** rewrite runtime-html decorators (#1960) ([eaf2cd7](eaf2cd7)) With tooling in the instable state for the tc39 decorator support, we will generate standard fn call code instead of decorator. This will likely be changed when browsers start officially supporting it, or at least when the tooling (both spec & tooling stability + compat) gets better **Features:** * **template:** support spread syntax with `spread` command and ... (#1965) ([ccae63b](ccae63b)) * **repeat:** allow custom repeatable value (#1962) ([c47df91](c47df91)) **Bug Fixes:** * **compiler:** fix order when spreading custom attribute into element bindable ([ccae63b](ccae63b)) * **au-slot:** separate parent scope selection from host scope selection (#1961) ([ff605fb](ff605fb)) **Refactorings:** * **kernel:** mark side effect free (#1964) ([22c8f71](22c8f71))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
As the wide support for TC39 decorators are still lacking, this PR refactors the convention-plugin to rewrite the following decorators:
Discord thread: https://discord.com/channels/448698263508615178/1230047298084409464
🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
⏭ Next Steps