feat(repeat): allow custom repeatable value #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ater-iterables
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1962 +/- ##
==========================================
- Coverage 88.62% 88.54% -0.08%
==========================================
Files 272 272
Lines 22823 22813 -10
Branches 5292 5280 -12
==========================================
- Hits 20226 20199 -27
- Misses 2597 2614 +17 ☔ View full report in Codecov by Sentry. |
elitastic
reviewed
May 6, 2024
AureliaEffect
pushed a commit
that referenced
this pull request
May 11, 2024
2.0.0-beta.17 (2024-05-11) **BREAKING CHANGES:** * **template:** auto infer binding expression when empty (#1963) ([3359939](3359939)) Previously only the expression of binding to element bindables get auto inferred, now it's expanded to all bindings with `.bind`/`.to-view`/`.from-view`/`.two-way`/`.one-time` Examples: ```html <div some-prop.bind=""> means <div some-prop.bind="someProp"> <div some-prop.bind> means <div some-prop.bind="someProp"> <div some-prop.one-time> means <div some-prop.one-time="someProp"> ... ``` * **convention:** rewrite runtime-html decorators (#1960) ([eaf2cd7](eaf2cd7)) With tooling in the instable state for the tc39 decorator support, we will generate standard fn call code instead of decorator. This will likely be changed when browsers start officially supporting it, or at least when the tooling (both spec & tooling stability + compat) gets better **Features:** * **template:** support spread syntax with `spread` command and ... (#1965) ([ccae63b](ccae63b)) * **repeat:** allow custom repeatable value (#1962) ([c47df91](c47df91)) **Bug Fixes:** * **compiler:** fix order when spreading custom attribute into element bindable ([ccae63b](ccae63b)) * **au-slot:** separate parent scope selection from host scope selection (#1961) ([ff605fb](ff605fb)) **Refactorings:** * **kernel:** mark side effect free (#1964) ([22c8f71](22c8f71))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
Currently the repeater only knows a fixed set of repeatable value, as we wanted to start simple. Though this is a missing capability from v1, where applications can register custom collection strategies to iterate and create views. In v2, we want to centralize view related work in the repeater, so exposing the ability to have a collection strategy to mostly iterate.
🎫 Issues
close #1703
close #851
cc @fkleuver @Sayan751