refactor(dom-queue): merge dom read and write queue #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1970 +/- ##
=======================================
Coverage 88.59% 88.59%
=======================================
Files 273 273
Lines 22946 22924 -22
Branches 5304 5297 -7
=======================================
- Hits 20328 20309 -19
+ Misses 2618 2615 -3 ☔ View full report in Codecov by Sentry. |
AureliaEffect
pushed a commit
that referenced
this pull request
May 23, 2024
2.0.0-beta.18 (2024-05-23) **BREAKING CHANGES:** * **dom-queue:** merge dom read and write queues (#1970) ([3a63cde](3a63cde)) **Features:** * **dialog:** ability to specify dialog per open call (#1978) ([7d44ed1](7d44ed1)) * **dialog:** add event manager for custom event handling extension ([7d44ed1](7d44ed1)) * **kernel:** add last resolver (#1976) ([c47817c](c47817c)) * **router-lite:** current route (#1966) ([d966e15](d966e15)) **Bug Fixes:** * **di:** use official metadata instead of weakmap (#1977) ([9aeeffa](9aeeffa)) * **router-lite:** current route subscription disposal (#1969) ([ace4c65](ace4c65)) * **convention:** typing: use array for bindables isntead of object (#1967) ([f1a73d6](f1a73d6)) **Refactorings:** * **collection:** define map & set overrides on the instance instead of prototype (#1975) ([253e92a](253e92a)) * **runtime:** reoganise utils import ([253e92a](253e92a)) * **fetch-client:** extract error codes and cleanup (#1974) ([63ffdc9](63ffdc9)) * **i18n-validation:** replace errors with error codes (#1972) ([f91f31c](f91f31c)) * **dev:** turbo package input glob + ts dev script ([253e92a](253e92a)) **Docs:** * **doc:** updated ISignaler documentation example (#1973) ([e0481d6](e0481d6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
When we first started, under the influence of a few other benchmarks, we went overboard with the dom queue making it unnecessarily cumbersome. This PR rectifies that: merge dom write queue and dom read queue together into a single queue.
Applications migrating to this don't need to take immediate action as the old properties
domWriteQueueanddomReadQueuewill still be there, albeit marked deprecated. These 2 properties will be removed in a near future, likely before RC.cc @fkleuver @Sayan751