Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router-lite): current route #1966

Merged
merged 4 commits into from
May 12, 2024
Merged

Conversation

Sayan751
Copy link
Member

Pull Request

πŸ“– Description

Related to #1819

🎫 Issues

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

⏭ Next Steps

Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 88.59%. Comparing base (4b0281e) to head (750aa3d).

❗ Current head 750aa3d differs from pull request most recent head f58427b. Consider uploading reports for the commit f58427b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1966   +/-   ##
=======================================
  Coverage   88.58%   88.59%           
=======================================
  Files         272      273    +1     
  Lines       22909    22946   +37     
  Branches     5302     5305    +3     
=======================================
+ Hits        20294    20329   +35     
- Misses       2615     2617    +2     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@Sayan751 Sayan751 marked this pull request as ready for review May 12, 2024 06:57
@Sayan751 Sayan751 requested a review from bigopon May 12, 2024 06:57
Copy link
Member

@bigopon bigopon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Sayan751 πŸ‘ only a cleanup comment.

packages/router-lite/src/current-route.ts Show resolved Hide resolved
@Sayan751 Sayan751 merged commit d966e15 into master May 12, 2024
4 of 6 checks passed
@Sayan751 Sayan751 deleted the topic/router-lite-current-route branch May 12, 2024 15:01
@Sayan751
Copy link
Member Author

@bigopon I have merged this PR; in case you have further comments, I will gladly open a follow-up PR for those.

AureliaEffect pushed a commit that referenced this pull request May 23, 2024
2.0.0-beta.18 (2024-05-23)

**BREAKING CHANGES:**

* **dom-queue:** merge dom read and write queues (#1970) ([3a63cde](3a63cde))

**Features:**

* **dialog:** ability to specify dialog per open call (#1978) ([7d44ed1](7d44ed1))
* **dialog:** add event manager for custom event handling extension ([7d44ed1](7d44ed1))
* **kernel:** add last resolver (#1976) ([c47817c](c47817c))
* **router-lite:** current route (#1966) ([d966e15](d966e15))

**Bug Fixes:**

* **di:** use official metadata instead of weakmap (#1977) ([9aeeffa](9aeeffa))
* **router-lite:** current route subscription disposal (#1969) ([ace4c65](ace4c65))
* **convention:** typing: use array for bindables isntead of object (#1967) ([f1a73d6](f1a73d6))

**Refactorings:**

* **collection:** define map & set overrides on the instance instead of prototype (#1975) ([253e92a](253e92a))
* **runtime:** reoganise utils import ([253e92a](253e92a))
* **fetch-client:** extract error codes and cleanup (#1974) ([63ffdc9](63ffdc9))
* **i18n-validation:** replace errors with error codes (#1972) ([f91f31c](f91f31c))
* **dev:** turbo package input glob + ts dev script ([253e92a](253e92a))

**Docs:**

* **doc:** updated ISignaler documentation example (#1973) ([e0481d6](e0481d6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants