Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve doc & cleanup #1983

Merged
merged 11 commits into from
May 27, 2024
Merged

chore: improve doc & cleanup #1983

merged 11 commits into from
May 27, 2024

Conversation

bigopon
Copy link
Member

@bigopon bigopon commented May 24, 2024

📖 Description

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 88.61%. Comparing base (be8fa67) to head (e21d13f).

Files Patch % Lines
packages/router/src/route.ts 50.00% 5 Missing ⚠️
packages/router/src/browser-viewer-store.ts 0.00% 3 Missing ⚠️
packages/router/src/endpoints/viewport-content.ts 0.00% 2 Missing ⚠️
packages/router/src/navigator.ts 0.00% 2 Missing ⚠️
packages/router/src/router.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1983      +/-   ##
==========================================
+ Coverage   88.58%   88.61%   +0.02%     
==========================================
  Files         278      278              
  Lines       22911    22908       -3     
  Branches     5292     5292              
==========================================
+ Hits        20295    20299       +4     
+ Misses       2616     2609       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bigopon bigopon merged commit 02921ca into master May 27, 2024
28 of 29 checks passed
@bigopon bigopon deleted the chore/cleanup-15 branch May 27, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Have doc to clarify the difference among binding usages
1 participant